Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add category property to commands #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style: add category property to commands #55

wants to merge 2 commits into from

Conversation

nriviere-gitguardian
Copy link

Context

The display of the commands was not standardized: some commands were not prepended by GitGuardian, and the others were using gitguardian instead of GitGuardian.

CleanShot 2024-11-13 at 11 26 57@2x

What has been done

Update package.json to group GitGuardian commands into the GitGuardian category.

Validation

Open the command palette and verify that GitGuardian commands are prepended by GitGuardian:

sevbch
sevbch reviewed Nov 13, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
sevbch
sevbch reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@sevbch sevbch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you've added "category": "GitGuardian" for all commands, but in your screenshot, where is the GitGuardian: prefix coming from? Isn't going to be doubled? (or is it already coming from this PR?)

salome-voltz
salome-voltz approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@salome-voltz salome-voltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! 🙏

package.json Outdated Show resolved Hide resolved
@nriviere-gitguardian nriviere-gitguardian force-pushed the nriviere/add-category-property-to-commands branch from a81f467 to 5fe2255 Compare November 14, 2024 08:47
@nriviere-gitguardian
Copy link
Author

So you've added "category": "GitGuardian" for all commands, but in your screenshot, where is the GitGuardian: prefix coming from? Isn't going to be doubled? (or is it already coming from this PR?)

It's coming from the views property: the VS Code automatically adds commands to open the views and prepend the command by the name of the extension, GitGuardian in this case.

I've added a commit to fix some case issues in the views names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevbch sevbch sevbch left review comments

@salome-voltz salome-voltz salome-voltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nriviere-gitguardian @sevbch @salome-voltz